Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor extract command with its tests #135

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: refactor extract command with its tests #135

merged 1 commit into from
Aug 31, 2023

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Aug 31, 2023 •
edited
Loading

Refactor for more usability and readability. And to prepare tests to deal with options to be added to extract command in future pull-requests

  • Get babel processing out of run method into a separate method named babel_extract
  • Refactor TestExtract to avoid calling the mocked extract command unless it's needed. Doing that by creating a decorator named perform_extract

Change log?

None, just a code refactor

@shadinaif
feat: refactor extract command with its tests
d7baf2c 
Refactor for more usability and readability. And to prepare
tests to deal with options to be added to extract command
in future pull-requests

Refs: FC-0012 OEP-58
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 31, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif
Copy link
Contributor Author

This one is ready @OmarIthawi , @brian-smith-tcril

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.27% 🎉

Comparison is base (c3a9831) 99.47% compared to head (d7baf2c) 99.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   99.47%   99.74%   +0.27%     
==========================================
  Files          10       10              
  Lines         381      399      +18     
  Branches       28       27       -1     
==========================================
+ Hits          379      398      +19     
+ Partials        2        1       -1
Files Changed Coverage Δ
tests/test_extract.py 100.00% <100.00%> (+2.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadinaif shadinaif mentioned this pull request Aug 31, 2023
Merged
3 tasks
@OmarIthawi OmarIthawi self-requested a review August 31, 2023 10:10
OmarIthawi
OmarIthawi approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @shadinaif!!

@OmarIthawi OmarIthawi merged commit 53b8f06 into openedx:master Aug 31, 2023
6 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi OmarIthawi deleted the shadinaif/general-refactor branch August 31, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi OmarIthawi approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadinaif @openedx-webhooks @OmarIthawi